Adds a plugin for empty hash formatting#532
Closed
adamof wants to merge 1 commit intoruby-syntax-tree:mainfrom
Closed
Adds a plugin for empty hash formatting#532adamof wants to merge 1 commit intoruby-syntax-tree:mainfrom
adamof wants to merge 1 commit intoruby-syntax-tree:mainfrom
Conversation
|
Surely this change is safe to make by default, and doesn't require a plugin. I prefer opinionated software that doesn't expose unnecessary options. |
Author
I think that make sense, but this is one my few open-source contributions so I'm not sure how is this decided :) @kddnewton happy to hear your thoughts |
Member
|
Once #543 is merged, this will be the default on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #406
Adds the ability to stop the formatter from splitting empty hashes
{}over multiple lines by introducingcompact_empty_hashplugin.Before formatting:
After formatting without the plugin
After formatting with the plugin